Dom update 2024-01-11 by sandersn · Pull Request #57027 · microsoft/TypeScript

sandersn · 2024-01-11T19:54:08Z

Not many breaks from this one. Two packages have their shims break and one package assigns to a property that's not there anymore (but might still be on the browser it targets?)

Performance:

the change makes the compiler use slightly more memory

Failures:

webrtc in DT (because it's a shim for WebRTC*)
pixijs incorrectly extends CanvasTextDrawingStyles -- because it was shimming letterSpacing, which was added non-optional.
tldraw assigns to now-missing FontFaceDescriptors.variant, though it's "just" an excess property error and will be ignored.

Summary of changes:

AuthenticationExtensionClientInputs pinLength new
BufferSource -> AllowSharedBufferSource in 18 places
NotificationAction deleted, and several properties of NotificationOptions
new properties in RTCEncodedAudio/VideoMetadata
other minor additions/removals in RTC*
WebTransportSendStreamOptions.sendOrder removes null from type
MIDIConnectionEvent.port adds null to type
More MDN links in jsdoc
minor additions in CSS*
CSSStyleRule now extends CSSGroupRule instead of CSSRule
CredentialsContainer.store no longer returns Credential, just void
FontFace.variant deleted
Gamepad.hapticActuators deleted
New event: beforetoggle
minor additions in HTML*Element
add Highlight/HighlightRegistry
midimessage now has type MIDIMessageEvent, not just Event
statechange now has type MIDIConnectionEvent
icecandidateerror now has type RTCPeerConnectionIceErrorEvent
minor additions in RTC*
RTCRtpSender.setParameters has new optional parameter
new property: SVGImageElement.crossOrigin
TextMetrics adds a few new properties
VideoFrame constructors now contruct from AllowSharedBufferSource instead of BufferSource
WEBGL_* switches from GLuint to number (also switches to AllowSharedBufferSource some places)
Window adds ondeviceorientationabsolute event

Copied from microsoft/typescript-dom-lib-generator

sandersn · 2024-01-11T19:54:46Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-01-11T19:54:48Z

Heya @sandersn, I've started to run the tarball bundle task on this PR at 3bae7b9. You can monitor the build here.

typescript-bot · 2024-01-11T19:54:48Z

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 3bae7b9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-11T19:54:48Z

Heya @sandersn, I've started to run the regular perf test suite on this PR at 3bae7b9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-11T19:54:48Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 3bae7b9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-11T19:54:48Z

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 3bae7b9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-11T19:56:44Z

Hey @sandersn, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159456/artifacts?artifactName=tgz&fileId=FDAB1F1F90D9CBCDAF908301B6CD1F3B31B1E4DFC80AE9E4600D1EF04512253102&fileName=/typescript-5.4.0-insiders.20240111.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-57027-6".;

typescript-bot · 2024-01-11T20:13:53Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/57027/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-11T20:38:40Z

Hey @sandersn, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: webrtc
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/webrtc/RTCPeerConnection.d.ts
  393:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'onicecandidateerror' must be of type '((this: RTCPeerConnection, ev: RTCPeerConnectionIceErrorEvent) => any) | null', but here has type 'PeerConnectionEventHandler<Event>'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240111/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240111/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

You can check the log here.

typescript-bot · 2024-01-11T20:58:42Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/57027/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
- Project Scope

pixijs/pixijs

tsconfig.json

error TS2430: Interface 'ICanvasRenderingContext2D' incorrectly extends interface 'CanvasTextDrawingStyles'.
- packages/settings/src/ICanvasRenderingContext2D.ts#L7

tsconfig.types.json

error TS2430: Interface 'ICanvasRenderingContext2D' incorrectly extends interface 'CanvasTextDrawingStyles'.
- packages/settings/src/ICanvasRenderingContext2D.ts#L7

tldraw/tldraw

1 of 5 projects failed to build with the old tsc and were ignored

apps/examples/tsconfig.json

error TS2353: Object literal may only specify known properties, and 'variant' does not exist in type 'FontFaceDescriptors'.
- packages/tldraw/src/lib/ui/hooks/usePreloadAssets.ts#L53 in packages/tldraw/tsconfig.json

apps/vscode/editor/tsconfig.json

error TS2353: Object literal may only specify known properties, and 'variant' does not exist in type 'FontFaceDescriptors'.
- packages/tldraw/src/lib/ui/hooks/usePreloadAssets.ts#L53 in packages/tldraw/tsconfig.json

apps/vscode/extension/tsconfig.json

error TS2353: Object literal may only specify known properties, and 'variant' does not exist in type 'FontFaceDescriptors'.
- packages/tldraw/src/lib/ui/hooks/usePreloadAssets.ts#L53 in packages/tldraw/tsconfig.json

typescript-bot · 2024-01-11T21:18:01Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,508k (± 0.01%)}	_{295,633k (± 0.01%)}	_{+125k (+ 0.04%)}	_295,601k	_295,703k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.15%)}	_{2.66s (± 0.31%)}	_~	_2.65s	_2.67s	_{p=0.527 n=6}
_{Bind Time}	_{0.82s (± 0.66%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.640 n=6}
_{Check Time}	_{8.13s (± 0.38%)}	_{8.12s (± 0.33%)}	_~	_8.08s	_8.16s	_{p=1.000 n=6}
_{Emit Time}	_{7.09s (± 0.36%)}	_{7.09s (± 0.55%)}	_~	_7.04s	_7.13s	_{p=0.686 n=6}
_{Total Time}	_{18.70s (± 0.20%)}	_{18.68s (± 0.30%)}	_~	_18.61s	_18.76s	_{p=0.872 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,924k (± 1.44%)}	_{192,480k (± 1.21%)}	_~	_191,501k	_197,247k	_{p=0.230 n=6}
_{Parse Time}	_{1.35s (± 0.56%)}	_{1.36s (± 0.60%)}	_~	_1.35s	_1.37s	_{p=0.383 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.37%)}	_{9.34s (± 0.18%)}	_~	_9.32s	_9.36s	_{p=0.333 n=6}
_{Emit Time}	_{2.64s (± 0.31%)}	_{2.63s (± 0.32%)}	_{-0.01s (- 0.44%)}	_2.62s	_2.64s	_{p=0.045 n=6}
_{Total Time}	_{14.07s (± 0.22%)}	_{14.04s (± 0.13%)}	_~	_14.03s	_14.07s	_{p=0.102 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,399k (± 0.01%)}	_{347,393k (± 0.01%)}	_~	_347,363k	_347,431k	_{p=0.810 n=6}
_{Parse Time}	_{2.47s (± 0.47%)}	_{2.46s (± 0.47%)}	_~	_2.44s	_2.47s	_{p=0.357 n=6}
_{Bind Time}	_{0.93s (± 0.00%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.174 n=6}
_{Check Time}	_{6.88s (± 0.63%)}	_{6.88s (± 0.47%)}	_~	_6.83s	_6.91s	_{p=0.746 n=6}
_{Emit Time}	_{4.05s (± 0.20%)}	_{4.05s (± 0.72%)}	_~	_4.02s	_4.10s	_{p=0.411 n=6}
_{Total Time}	_{14.33s (± 0.26%)}	_{14.32s (± 0.36%)}	_~	_14.25s	_14.41s	_{p=1.000 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,774k (± 0.01%)}	_{302,787k (± 0.00%)}	_~	_302,774k	_302,809k	_{p=0.065 n=6}
_{Parse Time}	_{2.01s (± 0.98%)}	_{2.00s (± 1.17%)}	_~	_1.96s	_2.02s	_{p=0.567 n=6}
_{Bind Time}	_{1.01s (± 1.04%)}	_{1.01s (± 1.49%)}	_~	_0.99s	_1.03s	_{p=1.000 n=6}
_{Check Time}	_{6.31s (± 0.47%)}	_{6.29s (± 0.31%)}	_~	_6.26s	_6.31s	_{p=0.360 n=6}
_{Emit Time}	_{3.58s (± 0.49%)}	_{3.57s (± 0.50%)}	_~	_3.55s	_3.59s	_{p=0.209 n=6}
_{Total Time}	_{12.89s (± 0.38%)}	_{12.88s (± 0.21%)}	_~	_12.83s	_12.91s	_{p=0.376 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{508,279k (± 0.00%)}	_{508,406k (± 0.00%)}	_{+128k (+ 0.03%)}	_508,385k	_508,447k	_{p=0.005 n=6}
_{Parse Time}	_{2.59s (± 0.40%)}	_{2.60s (± 0.72%)}	_~	_2.57s	_2.62s	_{p=0.933 n=6}
_{Bind Time}	_{1.00s (± 1.17%)}	_{0.99s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.401 n=6}
_{Check Time}	_{17.07s (± 0.54%)}	_{17.10s (± 0.61%)}	_~	_16.97s	_17.25s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.66s (± 0.45%)}	_{20.69s (± 0.56%)}	_~	_20.54s	_20.85s	_{p=0.521 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,970k (± 0.01%)}	_{513,336k (± 0.01%)}	_{+366k (+ 0.07%)}	_513,286k	_513,366k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 0.23%)}	_{3.28s (± 0.27%)}	_~	_3.27s	_3.29s	_{p=0.798 n=6}
_{Bind Time}	_{1.54s (± 0.34%)}	_{1.54s (± 0.00%)}	_~	_1.54s	_1.54s	_{p=0.174 n=6}
_{Check Time}	_{2.82s (± 0.48%)}	_{2.84s (± 0.82%)}	_~	_2.81s	_2.87s	_{p=0.460 n=6}
_{Emit Time}	_{0.07s (± 5.69%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=0.405 n=6}
_{Total Time}	_{7.71s (± 0.23%)}	_{7.73s (± 0.30%)}	_~	_7.70s	_7.76s	_{p=0.258 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,338ms (± 0.42%)}	_{2,345ms (± 0.89%)}	_~	_2,310ms	_2,369ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{5,555ms (± 1.23%)}	_{5,495ms (± 1.39%)}	_~	_5,405ms	_5,606ms	_{p=0.230 n=6}
_{Req 3 - references}	_{324ms (± 0.23%)}	_{325ms (± 1.27%)}	_~	_321ms	_332ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{271ms (± 0.60%)}	_{275ms (± 1.33%)}	_{+5ms (+ 1.66%)}	_270ms	_278ms	_{p=0.026 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{93ms (± 1.26%)}	_{86ms (± 6.65%)}	_~	_79ms	_93ms	_{p=0.118 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,488ms (± 0.47%)}	_{2,482ms (± 0.67%)}	_~	_2,465ms	_2,509ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{4,184ms (± 1.89%)}	_{4,162ms (± 1.83%)}	_~	_4,097ms	_4,264ms	_{p=0.936 n=6}
_{Req 3 - references}	_{330ms (± 0.37%)}	_{332ms (± 1.20%)}	_~	_328ms	_339ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{286ms (± 0.97%)}	_{285ms (± 0.53%)}	_~	_283ms	_286ms	_{p=0.615 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 3.66%)}	_{77ms (± 7.65%)}	_~	_74ms	_89ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,602ms (± 0.38%)}	_{2,615ms (± 0.66%)}	_~	_2,584ms	_2,630ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{1,711ms (± 2.73%)}	_{1,701ms (± 2.73%)}	_~	_1,650ms	_1,759ms	_{p=0.810 n=6}
_{Req 3 - references}	_{113ms (± 9.29%)}	_{116ms (± 9.47%)}	_~	_105ms	_126ms	_{p=0.865 n=6}
_{Req 4 - navto}	_{366ms (± 0.62%)}	_{366ms (± 0.68%)}	_~	_364ms	_371ms	_{p=0.807 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,078 (± 0.00%)}	_{+5 (+ 0.24%)}	_2,078	_2,078	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{308ms (± 2.26%)}	_{309ms (± 1.57%)}	_~	_303ms	_316ms	_{p=0.871 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{154.85ms (± 0.19%)}	_{154.77ms (± 0.19%)}	_{-0.08ms (- 0.05%)}	_153.70ms	_157.95ms	_{p=0.012 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.68ms (± 0.15%)}	_{230.57ms (± 0.17%)}	_{-0.11ms (- 0.05%)}	_229.30ms	_235.18ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.97ms (± 0.20%)}	_{231.12ms (± 0.19%)}	_{+0.15ms (+ 0.07%)}	_229.59ms	_236.65ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.78ms (± 0.19%)}	_{230.71ms (± 0.18%)}	_~	_229.16ms	_233.54ms	_{p=0.173 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

BickelLukas · 2024-03-11T10:44:44Z

NotificationAction deleted, and several properties of NotificationOptions

@sandersn Any insight as to why these have been deleted? Looking at the documentation on mdn these properties should exist: https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/showNotification

sandersn · 2024-03-12T18:02:38Z

It was based on microsoft/TypeScript-DOM-lib-generator#1631, which updates the types to @webref/idl@3.39.1 and browser-compat-data@5.3.21

The comments on that PR says that NotificationOptions is Blink-only as of 2023-10.

RulixConception · 2024-03-15T02:59:24Z

src/lib/dom.generated.d.ts


-interface NotificationAction {
-    action: string;
-    icon?: string;
-    title: string;
-}
-
 interface NotificationOptions {
-    actions?: NotificationAction[];
    badge?: string;
    body?: string;
    data?: any;
    dir?: NotificationDirection;
    icon?: string;
-    image?: string;
    lang?: string;
-    renotify?: boolean;
    requireInteraction?: boolean;
    silent?: boolean | null;
    tag?: string;
-    timestamp?: EpochTimeStamp;
-    vibrate?: VibratePattern;
 }


Why were those properties removed?

@RulixConception
https://github.com/microsoft/TypeScript-DOM-lib-generator?tab=readme-ov-file#when-the-type-is-missing

sandersn added 2 commits January 11, 2024 11:45

DOM update 2024-01-11

821ffca

Copied from microsoft/typescript-dom-lib-generator

update baselines

3bae7b9

typescript-bot assigned sandersn Jan 11, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 11, 2024

sandersn merged commit d69757e into microsoft:main Jan 16, 2024

sandersn deleted the dom-update-2024-01-11 branch January 16, 2024 19:32

RyanCavanaugh mentioned this pull request Jan 22, 2024

[NewErrors] 5.4.0-dev.20240121 vs 5.3.3 #57117

Closed

RulixConception reviewed Mar 15, 2024

View reviewed changes

nonara mentioned this pull request Apr 2, 2024

[BUG] with new version 11.0.24 motiondivision/motion#2602

Closed

kyledecot mentioned this pull request Nov 20, 2024

MIDIMessageEvent data is incorrectly typed #60546

Open

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

sandersn commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn commented Jan 11, 2024

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 11, 2024

Uh oh!

typescript-bot commented Jan 11, 2024

Uh oh!

typescript-bot commented Jan 11, 2024

Uh oh!

typescript-bot commented Jan 11, 2024

tsc

tsserver

startup

Uh oh!

BickelLukas commented Mar 11, 2024

Uh oh!

sandersn commented Mar 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sandersn commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading

typescript-bot commented Jan 11, 2024 •

edited

Loading